Fallback to realm if no domain is found in %d token expansion #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If username have no domain, the %d have to use the same value of %r, so the break will be executed only if a domain is found. Regression of 627d842 Signed-off-by: Andrea Redaelli <[email protected]>
andrea-reda
force-pushed
the
default_realm_fallback
branch
from
26558e4
to
6951a54
Compare
|
See issue #832 discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If username have no domain, the %d have to use the same value of %r, so the break will be executed only if a domain is found.
Regression found in 627d842